Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 linter fixes + updating PR lint rules #1130

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Flake8 linter fixes + updating PR lint rules #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
39aacfc
Wiring flake8 with the PR pipeline
teoparvanov Nov 8, 2024
e554695
Fixing code formatting issues reported by flake8
teoparvanov Nov 8, 2024
1fe5d4a
Update ubuntu.yml to use custom lint configs as in lint.yml
teoparvanov Nov 8, 2024
1dccbba
Revert "Fixing code formatting issues reported by flake8"
teoparvanov Nov 11, 2024
73ce1d3
Merge branch 'develop' into flake8-linter-fixes
MasterSkepticista Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install -r linters-requirements.txt
- name: Lint using built-in script
run: bash shell/lint.sh
- name: Lint with OpenFL-specific rules
run: bash shell/lint.sh
8 changes: 3 additions & 5 deletions .github/workflows/ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,12 @@ jobs:
uses: actions/setup-python@v3
with:
python-version: "3.8"
- name: Install dependencies
- name: Install linters
run: |
python -m pip install --upgrade pip
pip install -r linters-requirements.txt
pip install .
- name: Lint with flake8
run: |
flake8 --show-source
- name: Lint with OpenFL-specific rules
run: bash shell/lint.sh
teoparvanov marked this conversation as resolved.
Show resolved Hide resolved

pytest-coverage: # from pytest_coverage.yml
needs: lint
Expand Down
Loading