-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set FQDN as env variable for pytest coverage #1137
Set FQDN as env variable for pytest coverage #1137
Conversation
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
ubuntu.yaml pipeline was failed because of If we rerun pipeline(https://github.com/securefederatedai/openfl/actions/runs/11788591035) will be passed not sure if FQDN will help. |
It will, as the error is due to the excessively long FQDNs of GHA runners. The suggestion here is to use localhost as the (aggregator) FQDN instead. |
@rajithkrishnegowda - This error actually comes when we do not pass the FQDN and system picks the default domain name of given runner machine. Thus we have to explicitly provide the FQDN. It's already present in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @noopurintel !
Triggered jobs after making FQDN as global env: |
Problem - Pytest coverage is failing as part of Ubuntu and Windows nightly jobs. https://github.com/securefederatedai/openfl/actions/runs/11788591035/attempts/1
Reason - FQDN is missing in the environment section of above workflow yaml files.
After adding FQDN as localhost, it is working fine - https://github.com/payalcha/openfl/actions/runs/11792791416