Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set FQDN as env variable for pytest coverage #1137

Merged

Conversation

noopurintel
Copy link
Contributor

Problem - Pytest coverage is failing as part of Ubuntu and Windows nightly jobs. https://github.com/securefederatedai/openfl/actions/runs/11788591035/attempts/1

Reason - FQDN is missing in the environment section of above workflow yaml files.

After adding FQDN as localhost, it is working fine - https://github.com/payalcha/openfl/actions/runs/11792791416

@rajithkrishnegowda
Copy link
Collaborator

rajithkrishnegowda commented Nov 12, 2024

ubuntu.yaml pipeline was failed because of
FAILED tests/openfl/interface/test_aggregator_api.py::test_aggregator_generate_cert_request - ValueError: Attribute's length must be >= 1 and <= 64, but it was 65
======= 1 failed, 273 passed, 1 skipped, 2 warnings in 65.13s (0:01:05) ========

If we rerun pipeline(https://github.com/securefederatedai/openfl/actions/runs/11788591035) will be passed not sure if FQDN will help.

@teoparvanov
Copy link
Collaborator

teoparvanov commented Nov 12, 2024

ubuntu.yaml pipeline was failed because of FAILED tests/openfl/interface/test_aggregator_api.py::test_aggregator_generate_cert_request - ValueError: Attribute's length must be >= 1 and <= 64, but it was 65 ======= 1 failed, 273 passed, 1 skipped, 2 warnings in 65.13s (0:01:05) ========

If we rerun it pipeline will be passed not sure if FQDN will help.

It will, as the error is due to the excessively long FQDNs of GHA runners. The suggestion here is to use localhost as the (aggregator) FQDN instead.

@noopurintel
Copy link
Contributor Author

@rajithkrishnegowda - This error actually comes when we do not pass the FQDN and system picks the default domain name of given runner machine.
For Github runners - this is one example where I encountered the same error - fv-az1986-223.m0gpccztuiae5imzg12qvibqrh.bx.internal.cloudapp.net . It's clearly crossing the limit of 64 char.

Thus we have to explicitly provide the FQDN. It's already present in pytest_coverage.yaml file.

Copy link
Collaborator

@teoparvanov teoparvanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @noopurintel !

@noopurintel
Copy link
Contributor Author

Triggered jobs after making FQDN as global env:

  1. Ubuntu - https://github.com/noopurintel/openfl/actions/runs/11793213643
  2. Windows - https://github.com/noopurintel/openfl/actions/runs/11793214547

@teoparvanov teoparvanov merged commit 3301e57 into securefederatedai:develop Nov 12, 2024
28 checks passed
@noopurintel noopurintel deleted the pytest-coverage-fqdn-fix branch December 12, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants