[fix] parse compression pipeline from plan.yaml during fx model save
#1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kta-intel <[email protected]>
MasterSkepticista
approved these changes
Nov 16, 2024
MasterSkepticista
merged commit a977fb3
into
securefederatedai:develop
29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1142
This PR implements logic to parse the compression pipeline from plan.yaml in order to instantiate the correct pipeline to be used to deconstruct the model proto when calling
fx model saveOriginally, a model proto is constructed with the best/last models using some specified compression pipeline. These pipelines come with a
backward()pass to deconstruct the proto and extract the model. However, the default pipeline that is invoked withfx model saveis theNoCompressionPipeline(), which will raise an error if the original proto was constructed with a different pipeline. This PR ensures that the same pipeline is used in both construction and deconstruction of the model proto