Memory leak Details #1155
Closed
Memory leak Details #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chaurasiya, Payal <[email protected]>
added 2 commits
November 19, 2024 07:27
Signed-off-by: Ubuntu <azureuser@vm-openfl.edrucphba2zutobdsbafmzy3ya.bx.internal.cloudapp.net>
Signed-off-by: Ubuntu <azureuser@vm-openfl.edrucphba2zutobdsbafmzy3ya.bx.internal.cloudapp.net>
rahulga1
reviewed
Nov 19, 2024
| @@ -132,6 +132,8 @@ def modify_plan(self, new_rounds=None, num_collaborators=None, disable_client_au | |||
| data = yaml.load(fp, Loader=yaml.FullLoader) | |||
|
|
|||
| data["aggregator"]["settings"]["rounds_to_train"] = int(self.rounds_to_train) | |||
| data["aggregator"]["settings"]["memleak_check"] = True | |||
There was a problem hiding this comment.
in my opinion, we should enable this by default.
There was a problem hiding this comment.
Memory details are not needed for all runs. Basically it will be better for performance and Memory Leak related tests I think.
Please let me know if still needs to change this.
Signed-off-by: payalcha <[email protected]>
teoparvanov
reviewed
Nov 19, 2024
* deprecate python native api Signed-off-by: yes <[email protected]> * syntax issue fix Signed-off-by: yes <[email protected]> --------- Signed-off-by: yes <[email protected]>
Signed-off-by: payalcha <[email protected]>
teoparvanov
approved these changes
Nov 19, 2024
| @@ -171,6 +174,24 @@ def run(self): | |||
|
|
|||
| # Cleaning tensor db | |||
| self.tensor_db.clean_up(self.db_store_rounds) | |||
| if self.log_memory_usage: | |||
| # This is the place to check the memory usage of the collaborator | |||
| self.logger.info("*****************COLLABORATOR LOGS*******************************") | |||
There was a problem hiding this comment.
********* COLLABORATOR MEMORY USAGE *********?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.