Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskRunner E2E Workflow: corrections and enhancements #1161

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

noopurintel
Copy link
Contributor

  1. To print summary and collect logs in all the cases, irrespective of the previous step outcome.
  2. Pytest command on multi-line for better readability
  3. Failure reason along with status as part of GitHub summary.

Job run with the changes - https://github.com/noopurintel/openfl/actions/runs/11927821340

Copy link
Collaborator

@theakshaypant theakshaypant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just suggest the removal of now misleading (?) comments in certain files.

.github/workflows/task_runner_e2e.yml Outdated Show resolved Hide resolved
.github/workflows/task_runner_e2e.yml Outdated Show resolved Hide resolved
.github/workflows/task_runner_e2e.yml Outdated Show resolved Hide resolved
.github/workflows/task_runner_e2e.yml Outdated Show resolved Hide resolved
.github/workflows/task_runner_e2e.yml Outdated Show resolved Hide resolved
.github/workflows/task_runner_e2e.yml Outdated Show resolved Hide resolved
@teoparvanov teoparvanov merged commit 4ea9eba into securefederatedai:develop Nov 20, 2024
29 checks passed
@noopurintel noopurintel deleted the noopur/tr-wf-fix branch December 12, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants