-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Keras and TensorFlow Task Runner and related workspaces. #1174
Conversation
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
I will add code changes for the remaining Keras workspace - Keras_cnn_with_compression and keras_nlp. @teoparvanov @kta-intel @psfoley, I was facing an issue with optimizer weights due to resetting the weights before saving them to the tensor database and using them to rebuild the model, which resulted in no improvement in accuracy. I have skipped the rebuild (and hence resetting the model optimizer weights) for the first round. This can be further discussed, and we can proceed with these changes once all the pipelines are working and the workspace changes are also completed. |
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is openfl setup not affected by these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reader cannot tell what this example is about (model/use case). Suggest adding a header (also making the license header consistent with other files) that tells what architecture, and what use case this example is for.
I think this is a good place to refactor the directory structure: openfl-workspace (in future, "examples")
|_ keras
| |_ mnist
| |_ lstm
|_ (other backends in future PRs) Thoughts? |
@MasterSkepticista , would it be acceptable to do this in a follow-up PR? |
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks @tanwarsh ! This PR brings OpenFL back into the TensorFlow game 😉
No this will not affect openfl setup. |
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
@teoparvanov @MasterSkepticista @kta-intel As discussed I have migrated workspaces mentioned below to latest tensorflow and keras 3 versions and rest of the workspaces are removed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related issue #973.
Changes in this PR: