Migration to ruff #1176
Merged
Migration to ruff #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shah, Karan <[email protected]>
MasterSkepticista
force-pushed
the
karansh1/ruff_migration
branch
2 times, most recently
from
bc2c8a2 to
e976d19
Compare
| setattr(f.__func__, "_stream_buffer", pickle.loads(stream_buffer)) | ||
| f.__func__._stream_buffer = pickle.loads(stream_buffer) |
There was a problem hiding this comment.
This is an example of simplification automatically made by ruff.
Signed-off-by: Shah, Karan <[email protected]>
|
@MasterSkepticista Can you please add changes for Check code format pipeline as well. |
It is updated, I'm refactoring warnings raised by ruff, few of the remaining ones are mentioned in #1177. Would appreciate any help! |
MasterSkepticista
force-pushed
the
karansh1/ruff_migration
branch
from
0b74d2d to
bde431b
Compare
Signed-off-by: Shah, Karan <[email protected]>
Signed-off-by: Shah, Karan <[email protected]>
MasterSkepticista
merged commit 58eeac9
into
securefederatedai:develop
28 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates all lint/format tooling to ruff, a modern, fast, rust-based formatter with significantly more capabilities.
Ruff has a drop-in parity with flake8, black and isort - all linting tools used in OpenFL. All config now resides in
pyproject.toml.