Functional workflow for LocalRuntime APIs #1220
Conversation
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
payalcha
changed the title
tests/github/experimental/workflow/LocalRuntime/testflow_subset_of_collaborators.py
Outdated
Show resolved
Hide resolved
tests/github/experimental/workflow/LocalRuntime/testflow_subset_of_collaborators.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Add copyright message to the top of each file in the "tests/end_to_end/workflow/" folder. * Add the copyright message to `exclude_flow.py` * Add the copyright message to `include_exclude_flow.py` * Add the copyright message to `include_flow.py` * Add the copyright message to `internal_loop.py` * Add the copyright message to `private_attr_both.py` * Add the copyright message to `private_attr_wo_callable.py` * Add the copyright message to `private_attributes_flow.py` * Add the copyright message to `reference_exclude.py` * Add the copyright message to `reference_flow.py` * Add the copyright message to `reference_include_flow.py` * Add the copyright message to `subset_flow.py` Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
payalcha
force-pushed
the
functional-workflow
branch
from
e3f2b14 to
b93927e
Compare
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
rajithkrishnegowda
merged commit ba94a4b
into
securefederatedai:develop
| @@ -0,0 +1,95 @@ | |||
| --- | |||
| #--------------------------------------------------------------------------- | |||
| # Workflow to run Task Runner E2E tests via Docker | |||
There was a problem hiding this comment.
Instead of "Task Runner E2E tests" we can mention "Workflow Interface E2E Tests for LocalRuntime"
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
| class TestFlowExclude(FLSpec): |
There was a problem hiding this comment.
Query: The original test case seems to have a functionality where the class attribute exclude_error_list maintained the step in which the error occurred to help with troubleshooting. Is there a reason why that was removed ?
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
| class TestFlowIncludeExclude(FLSpec): |
There was a problem hiding this comment.
Query: Same comment as in TestflowExclude. Wondering the reason to modify the flow to remove include_exclude_error_list which could potentially help with debugging
| logging.basicConfig(level=logging.INFO) | ||
| log = logging.getLogger(__name__) | ||
|
|
||
| class TestFlowInternalLoop(FLSpec): |
There was a problem hiding this comment.
We can add the purpose of the Flow (missing in original test cases): Testflow to validate the Internal Loop functionality
| log = logging.getLogger(__name__) | ||
|
|
||
| class TestFlowPrivateAttributesBoth(FLSpec): | ||
| """ |
There was a problem hiding this comment.
Can we mention that in this test, the private attributes are initialized by both methods: callable as well as dictionary.
|
|
||
|
|
||
| class TestFlowPrivateAttributesWoCallable(FLSpec): | ||
| """ |
There was a problem hiding this comment.
Can we mention that in this Test the private attributes are initialized directly
|
|
||
| class TestFlowPrivateAttributes(FLSpec): | ||
| """ | ||
| Testflow to validate Aggregator private attributes are not accessible to collaborators |
There was a problem hiding this comment.
Can we mention that in this test, private attributes are initialized by callable
| """ | ||
|
|
||
| step_one_collab_attrs = [] | ||
| step_two_collab_attrs = [] |
There was a problem hiding this comment.
What is the reason for removing the functionality related to all_ref_error_dict attribute in the original test case? I am not able to recollect the exact reason this attribute was used and therefore the query
Adding functional tests of Workflow APIs into pull request.
Converted all test scripts except datastore_cli to functional test.