Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace xml.etree.ElementTree.parse with its defusedxml #1230

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

payalcha
Copy link
Contributor

@payalcha payalcha commented Dec 26, 2024

Replace xml.etree.ElementTree.parse with its defusedxml in summary_helper.py and requirements.txt.

Fix for log_memory_usage tests post callback changes.

https://github.com/payalcha/openfl/actions/runs/12505556806 - Task runner E2E

Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Copy link
Collaborator

@theakshaypant theakshaypant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The 3.10 ubuntu TaskRunner test failure looks like an intermittent failure?

@rajithkrishnegowda rajithkrishnegowda merged commit 18cda3e into securefederatedai:develop Dec 27, 2024
25 checks passed
porteratzo pushed a commit that referenced this pull request Jan 6, 2025
* Replace xml.etree.ElementTree.parse with its defusedxml

Signed-off-by: Chaurasiya, Payal <[email protected]>

* convert to json

Signed-off-by: Chaurasiya, Payal <[email protected]>

* Fix memory logs and create pdf

Signed-off-by: Chaurasiya, Payal <[email protected]>

---------

Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: porteratzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants