Fix Aggregator / Assigner leaky abstraction #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishaileshpant
changed the title
ishaileshpant
force-pushed
the
fix_leaky_abstraction
branch
2 times, most recently
from
f40af12 to
f2c1606
Compare
ishaileshpant
force-pushed
the
fix_leaky_abstraction
branch
4 times, most recently
from
ea1541b to
22b5869
Compare
ishaileshpant
changed the title
- update all the sub-classes that use task_groups to use the decorator - update fedeval sample workspace to use default assigner, tasks and aggregator - use of federated-evaluation/aggregator.yaml for FedEval specific workspace example to use round_number as 1 - removed assigner and tasks yaml from defaults/federated-evaluation, superseded by default assigner/tasks - added additional checks for assigner sub-classes that might not have task_groups - Addressing review comments - Updated existing test cases for Assigner sub-classes - Remove hard-coded setting in assigner for torch_cnn_mnist ws, refer to default as in other Workspaces - Use aggregator supplied --task_group to override the assinger selected_task_group - update existing test cases of aggregator cli - add test cases for the decorator - Rebased 2-Feb.2 Signed-off-by: Shailesh Pant <[email protected]>
- Added is_task_group_evaluation function in Assigner class - Fix existing aggregator interface test cases - rebased 2-Feb.2 Signed-off-by: Shailesh Pant <[email protected]>
ishaileshpant
force-pushed
the
fix_leaky_abstraction
branch
from
22b5869 to
308e762
Compare
rahulga1
approved these changes
Feb 3, 2025
kta-intel
approved these changes
Feb 3, 2025
theakshaypant
approved these changes
Feb 4, 2025
psfoley
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #1226 task_group is passed to Aggregator and awareness of task_group name is leaked b/w Assigner and Aggregator, to fix this Aggregator should rely on Assigner instead of hardcoding task_group names across multiple classes