Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupt shard utils and experiments #389

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

igor-davidyuk
Copy link
Contributor

This PR introduces Corrupting Shard Descriptor wrapper.

Decorating a Shard Descriptor (SD) class with this function will result in the following:

  1. corrupt parameter is added to the SD init function.
    The Envoy manager may enable corruption by putting corrupt: true to SD params.
  2. spoil_method passed to the wrapper will be used to spoil Shard Datasets of this Envoy
    if corruption is enabled.

@igor-davidyuk igor-davidyuk changed the title Corrupted shard utils and experiments Corrupt shard utils and experiments Mar 18, 2022
@alexey-gruzdev alexey-gruzdev added this to the v1.3.1 milestone Mar 31, 2022
@mansishr
Copy link
Collaborator

mansishr commented Apr 1, 2022

I think adding a separate folder with 'workspace_corruption_experiment' (which has a different format) may confuse the user and they might think that we can't use corrupt shard wrapper with regular Jupyter notebook (unless we show the accuracy difference in experiments between corrupt and non corrupt collaborators)

@psfoley psfoley modified the milestones: v1.3.1, v1.4 Jul 6, 2022
@Einse57 Einse57 modified the milestones: v1.4, v1.5 Aug 30, 2022
@psfoley psfoley modified the milestones: v1.5, v1.6 Dec 12, 2022
@theakshaypant
Copy link
Collaborator

@igor-davidyuk can you please resolve the conflicts and request for review again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants