Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create interfaces for OpenFL components with methods that can be impl… #816

Closed
wants to merge 1 commit into from

Conversation

danhe1
Copy link
Contributor

@danhe1 danhe1 commented Apr 28, 2023

Create interfaces for OpenFL components with methods that can be implementedCreate interfaces for OpenFL components with methods that can be implemented.

Create AggregatorInterface and CollaboratorInterface in openflinterface/interactive_api/experiment.py Support passing the aggregator object and collaborator object in the method FLExperiment.start() If aggregator object or collaborator object is None, the default aggregator and collaborator objects will be created at director and envoy services.

Known issue:
Since the AggregatorInterface and CollaboratorInterface are for ad-hoc algorithm development. We should modify the definitions of the model, data loader and task interfaces, since we are going to support some algorithms other than Keras, TensorFlow or PyTorch.

Fixes #802

…ementedCreate interfaces for OpenFL components with methods that can be implemented

    Create AggregatorInterface and CollaboratorInterface in openflinterface/interactive_api/experiment.py
    Support passing the aggregator object and collaborator object in the method FLExperiment.start()
    If aggregator object or collaborator object is None, the default aggregator and collaborator objects will
    be created at director and envoy services.

    Known issue:
    Since the AggregatorInterface and CollaboratorInterface are for ad-hoc algorithm development. We should modify the
    definitions of the model, data loader and task interfaces, since we are going to support some algorithms other than Keras, TensorFlow or PyTorch.

    Fixes securefederatedai#802

    Signed-off-by: He, Dan H <[email protected]>
    Signed-off-by: Jiang, Jiaqiu <[email protected]>
    Signed-off-by: Li, Qingqing <[email protected]>
    Signed-off-by: Wang, Le <[email protected]>
    Signed-off-by: Wu, Caili <[email protected]>
    Signed-off-by: He, Dan H <[email protected]>

Signed-off-by: He, Dan H <[email protected]>
@psfoley
Copy link
Contributor

psfoley commented May 23, 2023

@danhe1 and team, thanks for the submission. The maintainer team has determined that there will be a larger refactoring of the code necessary to support the interfaces proposed in #802, so we are going to close this PR for now. If you're interested in staying involved here, I'll loop you into future conversations in this space. I expect this will come in around the OpenFL ~1.7 timeframe.

@psfoley psfoley closed this May 23, 2023
@danhe1
Copy link
Contributor Author

danhe1 commented May 24, 2023

@danhe1 and team, thanks for the submission. The maintainer team has determined that there will be a larger refactoring of the code necessary to support the interfaces proposed in #802, so we are going to close this PR for now. If you're interested in staying involved here, I'll loop you into future conversations in this space. I expect this will come in around the OpenFL ~1.7 timeframe.

Hi, Patrick. Thanks for your comment. I agree that we need to modify a lot of related code for this issue. We are glad if we can continuing contributing to this issue. By saying OpenFL 1.7, I guess this means the 2nd half of this year. We are wondering how should we get involved in the development? What part are we responsible to? Maybe we can talk more about it when we get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create interfaces for OpenFL components with methods that can be implemented
2 participants