Stop suppressing gandlf config errors #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If gandlf config cannot be parsed properly (typos, wrong values, etc), now the error is just suppressed without any meaningful error and `gandlf_config` variable is just broken. Fix ensures 1. runner fails if gandlf config cannot be parsed, 2. if any errors, they are printed to logs with their stacktrace Signed-off-by: Viacheslav Kukushkin <[email protected]>
psfoley
approved these changes
Apr 29, 2024
|
Thanks for the contribution @VukW! Approved and merged. |
manuelhsantana
pushed a commit
that referenced
this pull request
Jul 10, 2024
If gandlf config cannot be parsed properly (typos, wrong values, etc), now the error is just suppressed without any meaningful error and `gandlf_config` variable is just broken. Fix ensures 1. runner fails if gandlf config cannot be parsed, 2. if any errors, they are printed to logs with their stacktrace Signed-off-by: Viacheslav Kukushkin <[email protected]> Signed-off-by: manuelhsantana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If gandlf config cannot be parsed properly (typos, wrong values, etc), now the error is just suppressed without any meaningful error and
gandlf_configvariable is just broken.Fix ensures