Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
setup.py
install_requires
tonumpy>2
Background: NumPy recently had a major release (v2.0.0) that has some potential downstream issues with packages compiled for NumPy 1.x
source
Issue: This impacts at least PyTorch versions earlier than v2.3 (i.e. PyTorch Task Runner)
Proposed resolution: Pin install requirement to
numpy<2
Rationale: With
python v3.9+
installing OpenFL will automatically install NumPy 2.0.0. By pinning to NumPy 1.x, this will allow OpenFL to continue to support earlier versions of PyTorch as well as avoid any potential issues caused in other packages.Another potential resolution would be to update all PyTorch examples and workspaces to
2.3.0+
, but older torch versions might not work, and we might not catch other potential downstream issues.