-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unit tests use tas pipeline #244
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: miyunari The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
64660d1
to
77dfa91
Compare
You need to update the cosign on-push and pull to use the new task, eg: https://github.com/securesign/gitsign/blob/main/.tekton/gitsign-pull-request.yaml#L366-L375 |
77dfa91
to
f78bb1e
Compare
Ok ty, I added it - and hopefully in the correct way - could you check again @JasonPowr ? :) |
@JasonPowr I hope I addressed all of the points you suggested in the right way? I am also super unsure if I chose the right quay images... :/ Do you know why the tests are still failing or what else could be wrong? Thanks for your help already 🤗 |
@miyunari The review comments I just made should help to resolve the pipelines not running :), |
Thanks a lot for all of your help @JasonPowr ! It seems the pipeline needs a lot of time to run, is that normal? And two of the Konflux steps already failed - https://github.com/securesign/cosign/pull/244/checks?check_run_id=29302067611 |
@miyunari Sometimes when there is a lot of load on the konflux servers it can act strange i.e taking ages for a pipeline to run, The ones that have run I am seeing a failure in the unit tests for cosign eg https://console.redhat.com/application-pipeline/workspaces/rhtas/applications/cli/pipelineruns/client-server-cg-on-pull-request-fqcws And no worries :) happy to help |
/retest |
9072f12
to
1109a43
Compare
Signed-off-by: Janine Olear <[email protected]>
e1b736a
to
4fef38c
Compare
This PR should run the Cosign unit tests with the Konflux pipeline.
I used these PRs as examples and guidelines:
securesign/trillian#197
securesign/fulcio#175
securesign/gitsign#145
jira: https://issues.redhat.com/browse/SECURESIGN-1295