update keycloak resources and tas-env script #190
Conversation
|
oops accidentally closed this, and re-opened now |
| export BASE_HOSTNAME=apps.$(oc get dns cluster -o jsonpath='{ .spec.baseDomain }') | ||
| echo "base hostname = $BASE_HOSTNAME" | ||
| # This assumes you are currently running from the context of the namespace where your securesign is created | ||
| # Run `oc project <securesign namespace>` to ensure you are working within the correct context |
There was a problem hiding this comment.
this should accept an env var for the securesign namespace but I'm being lazy here and maybe can be done in a follow-up
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, sallyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| export COSIGN_OIDC_ISSUER=$KEYCLOAK_URL/auth/realms/$KEYCLOAK_REALM | ||
| export COSIGN_CERTIFICATE_OIDC_ISSUER=$COSIGN_OIDC_ISSUER | ||
| export COSIGN_OIDC_ISSUER=$OIDC_ISSUER_URL | ||
| export COSIGN_OIDC_CLIENT_ID=trusted-artifact-signer |
There was a problem hiding this comment.
I don't know how important the go binary installer is to GA, but I remember there being issues for TP2 with theses variables not being up-to-date with https://github.com/securesign/sigstore-ocp/blob/release-1.0.gamma/tas-installer/cmd/envgen.go#L33
So they may need an update too
There was a problem hiding this comment.
I updated the script sigstore -> trusted-artifact-signer and also added the CLIENT_ID env var there
sallyom
force-pushed
the
update-keycloak-tas-env-vars
branch
from
df106f4
to
495701d
Compare
|
New changes are detected. LGTM label has been removed. |
sallyom
force-pushed
the
update-keycloak-tas-env-vars
branch
from
d1827ed
to
fd2b971
Compare
Signed-off-by: sallyom <[email protected]>
Signed-off-by: sallyom <[email protected]>
Signed-off-by: sallyom <[email protected]>
Signed-off-by: sallyom <[email protected]>
sallyom
force-pushed
the
update-keycloak-tas-env-vars
branch
from
fd2b971
to
c3c90f5
Compare
|
closing this, will open against main! |
@lance @cooktheryan update this first, then update main to match release-1.0.gamma?