Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: u128 deser errors #19

Merged
merged 7 commits into from
Aug 20, 2024
Merged

Fix: u128 deser errors #19

merged 7 commits into from
Aug 20, 2024

Conversation

gluax
Copy link
Contributor

@gluax gluax commented Aug 19, 2024

Motivation

Fix the deserialization errors caused by recent changes

Explanation of Changes

List of changes:

  1. Make a Uint128 type for the not cosmwasm side. That can correctly serialize and deserialize.
  2. Add lots of quality of life/ergonomics on said type.
  3. Change factory to return top-level ExecuteMsg, this fixes some errors on the overlay side and makes it cleaner.
  4. Adds new tests to test ser and deser for types.

Testing

Adds new tests old, tests pass.

Related PRs and Issues

N/A

@gluax gluax self-assigned this Aug 19, 2024
Copy link
Member

@FranklinWaller FranklinWaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the tests :)

@FranklinWaller FranklinWaller merged commit 54a5e77 into main Aug 20, 2024
2 checks passed
@FranklinWaller FranklinWaller deleted the fix/u128-deser-errors branch August 20, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants