Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(header): add support for x-seda-json-path #5

Merged
merged 1 commit into from
Aug 21, 2024
Merged

feat(header): add support for x-seda-json-path #5

merged 1 commit into from
Aug 21, 2024

Conversation

FranklinWaller
Copy link
Member

Motivation

This way a overlay node can use jsonPath to send less information across the wire and do less processing.

Explanation of Changes

  • add x-seda-json-path which comes after the jsonPath processing of the config.json

Thomasvdam
Thomasvdam approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@Thomasvdam Thomasvdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion for the JSONpath comment. Maybe good to add an TODO/issue to prevent the double JSON serialisation/deserialisation and apply the paths in series?

workspace/data-proxy/src/proxy-server.ts Outdated Show resolved Hide resolved
workspace/data-proxy/src/proxy-server.ts Outdated Show resolved Hide resolved
@FranklinWaller FranklinWaller merged commit 64a5bd6 into main Aug 21, 2024
2 checks passed
@Thomasvdam Thomasvdam deleted the feat/json-path-header branch August 21, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomasvdam Thomasvdam Thomasvdam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FranklinWaller @Thomasvdam