Fix duplicate names for same process by counting up processes in adapter #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2024
Merged
henhuy
force-pushed
the
fix/duplicate_names
branch
from
7dfa9bd to
8d1d698
Compare
FelixMau
approved these changes
Mar 1, 2024
nailend
reviewed
Mar 1, 2024
Comment on lines
+39
to
+42
| mapper.get("region"), | ||
| mapper.get("carrier"), | ||
| mapper.get("tech"), | ||
| self.counter, |
There was a problem hiding this comment.
Why dont we pass the process name? defaults.update({"name": mapper.process_name})
There was a problem hiding this comment.
Good idea. Counting must still be added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before name was only generated from region, carrier and tech - this leads to an error if multiple processes (with same tech and carrier) are placed into same region. Thus, I simply added a counter which adds a number to the name for each process.