Move custom input to attribute UI part plus some refactoring #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdp-cloud
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the UI to handle setting on a sample attribute whether is allows free text.
Also some refactoring around the attribute-type-handlers so that they take the attribute in the initializer.
Also some refactoring to simplify how the handlers are used, so that they are used via the attribute rather than sample type. This was mainly being done through delegation anyway so makes things simpler
Final step to do is to change the "AttributeTypeHandlers" into just "AttributeHandlers" - they currently take the base_type and attribute, but it is now possible to get the base_type via the attribute. This will mostly require updating tests, but will be done as a separate PR to avoid large PRs