Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement secure cookies by default #2107

Merged
merged 9 commits into from
Jan 24, 2025
Merged

Implement secure cookies by default #2107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e43d0ed
Force SSL in production
kdp-cloud Jan 8, 2025
3c718f8
Use secure cookies in production
kdp-cloud Jan 8, 2025
6913e51
Make secure cookie implementation dependent on a environmental variable
kdp-cloud Jan 15, 2025
78a9545
Revert secure cookies
kdp-cloud Jan 22, 2025
3346780
Set session cookie to lax
kdp-cloud Jan 22, 2025
35acf70
Set SameSite directive for auth_token cookie
kdp-cloud Jan 22, 2025
9dcdd2c
Set SameSite directive for cookie consent
kdp-cloud Jan 22, 2025
662d794
Revert force_ssl
kdp-cloud Jan 22, 2025
170140d
Revert "Set SameSite directive for cookie consent"
kdp-cloud Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/sessions_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def successful_login(notice = nil)
flash[:notice] = notice || "You have successfully logged in, #{@user.display_name}."
if params[:remember_me] == 'on'
@user.remember_me unless @user.remember_token?
cookies[:auth_token] = { value: @user.remember_token, expires: @user.remember_token_expires_at }
cookies[:auth_token] = { value: @user.remember_token, expires: @user.remember_token_expires_at, same_site: :strict }
end
respond_to do |format|
return_to_path = determine_return_path_after_login
Expand Down
2 changes: 1 addition & 1 deletion config/initializers/session_store.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
# (create the session table with "rails generate session_migration")
SEEK::Application.config.session_store(:active_record_store,
key: '_seek_session',
expire_after: Seek::Config.session_store_timeout)
expire_after: Seek::Config.session_store_timeout, same_site: :lax)
Loading