Upgrade to Rails 7.2 and Ruby 3.3 #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unused(?) `attachment_fu` which was causing load errors. * Bump `attr_encrypted` to avoid clash with new Rails method names.
Use `after_initialize` in various initializers that rely on `Settings` model before it is loaded.
Also hack around complaints about modules/classes not being defined in certain lib files (e.g. object_extensions.rb) (This needs a better solution)
This reverts commit 2787039.
tested build and running a basic container
was locked to a version to get a round a problem with ruby 3.1
WorkGroupDeleteError doesn't appear to be used
might want to rename to ISATabConverter when renaming the other Isa* stuff
although a little odd to be Rightfield::Rightfield
… of after_initialize
fixes ActiveSupport::ProxyObject deprecation warning
…ocker compose and testing
gives a lot of errors where we use a callback from ApplicationController, but the current controller doesn't support all the actions
…ntegration-tests Rails 7 fix isa exporter integration tests
fbacall
reviewed
Jan 15, 2025
stuzart
commented
Jan 16, 2025
stuzart
commented
Jan 16, 2025
stuzart
commented
Jan 16, 2025
stuzart
commented
Jan 16, 2025
an issue with Ransack as part of the rails 7 upgrade, which can be looked at separately as part of another ongoing issue #1548
Isa->ISA rename needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the changes required for the upgrade.
No need for a full details review of this large PR, but check for unexpectedly added files and silly errors.