Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 24.04 test fix #2160

Merged
merged 4 commits into from
Apr 7, 2025
Merged

Ubuntu 24.04 test fix #2160

merged 4 commits into from
Apr 7, 2025

Conversation

stuzart
Copy link
Member

@stuzart stuzart commented Mar 5, 2025

Updated the test to check for a string that works with both Ubuntu 22.04 and 24.04

a test run to show that both work: https://github.com/seek4science/seek/actions/runs/13677186559

This fixes a test but not the underlying issue.

it was caused by slight differences in the libre-office, but underlying problem is described in the following issue

@stuzart stuzart added this to the 1.17.0 milestone Mar 5, 2025
@stuzart stuzart moved this to In review in SEEK 1.17.x Mar 11, 2025
@stuzart stuzart requested a review from Copilot April 7, 2025 12:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@stuzart stuzart requested a review from kdp-cloud April 7, 2025 12:41
@stuzart stuzart merged commit b22aa0a into main Apr 7, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in SEEK 1.17.x Apr 7, 2025
@stuzart stuzart deleted the ubuntu24-test-fix branch April 7, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants