Skip to content

Make default iframe sandbox only require :blob csp permission #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

silesky
Copy link
Contributor

@silesky silesky commented May 4, 2025

No description provided.

Copy link

changeset-bot bot commented May 4, 2025

🦋 Changeset detected

Latest commit: 98ff882

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@segment/analytics-signals-runtime Minor
@segment/analytics-signals Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 4, 2025

Codecov Report

Attention: Patch coverage is 5.00000% with 57 lines in your changes missing coverage. Please review.

Project coverage is 84.51%. Comparing base (3f15dfa) to head (98ff882).

Files with missing lines Patch % Lines
...ages/signals/signals/src/core/processor/sandbox.ts 5.08% 56 Missing ⚠️
...gnals/src/core/middleware/event-processor/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1290      +/-   ##
==========================================
+ Coverage   82.87%   84.51%   +1.64%     
==========================================
  Files         225      221       -4     
  Lines        6019     5871     -148     
  Branches     1365     1342      -23     
==========================================
- Hits         4988     4962      -26     
+ Misses       1031      909     -122     
Flag Coverage Δ
browser 92.21% <ø> (ø)
core 89.86% <ø> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@silesky silesky force-pushed the add-more-secure-iframe-sandbox branch from c4f3303 to 302d772 Compare May 4, 2025 00:30
@silesky silesky requested a review from alanjcharles May 5, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants