Skip to content

Added support for taking catalog for the database to support S3tables operations through this library #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tejaoleria
Copy link

At first, thanks a lot for creating this small, yet very useful library that implements sql abstraction for AWS Athena.

With the introduction of S3tables, a managed Apache Iceberg offering from AWS, the Athena's query execution input should include the S3 table bucket information through Catalog property. This PR extends the driver to allow for specifying the catalog name in the connection string and use it in the query context accordingly.

An integration test has been added to verify that the simple SQL queries work on the S3 table bucket by providing the catalog information. Here is the output

> go test -v -run TestDriverWithCatalog          
=== RUN   TestDriverWithCatalog
--- PASS: TestDriverWithCatalog (21.72s)
PASS
ok      github.com/segmentio/go-athena  22.012s

@tejaoleria
Copy link
Author

@bhavanki can you please review. thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant