-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example of partial batch failure handling in Destination Function [FUNK] #6922
Open
sudojatin
wants to merge
10
commits into
develop
Choose a base branch
from
func_batch
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 24.35.1
Release 24.31.2
Release 24.32.1
Release 24.32.2
pwseg
previously approved these changes
Feb 13, 2025
The merge-base changed after approval.
pwseg
previously approved these changes
Feb 13, 2025
The merge-base changed after approval.
pwseg
previously approved these changes
Mar 6, 2025
pwseg
previously approved these changes
Mar 6, 2025
@Ashwithabg Could you take a look at this? Need your review before merging. |
twfarhan
previously approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content-update
updates to content that are not new features, includes grammar fixes, added notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add example of partial batch failure for destination function
Proposed changes
This PR adds an example of partial batch failure handling in destination function
Merge timing
ASAP once approved
Related issues (optional)