Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Fix timestamp in evm read calls #1486

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Conversation

stevenlanders
Copy link
Contributor

@stevenlanders stevenlanders commented Mar 27, 2024

Describe your changes and provide context

  • this uses the block context passed through the api
  • otherwise create the default latest context (existing)

Testing performed to validate your change

  • manual api calls
  • hardhat test for tracing
  • hardhat test for block properties

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.73%. Comparing base (4e37d32) to head (fe142e6).
Report is 212 commits behind head on seiv2.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            seiv2    #1486      +/-   ##
==========================================
+ Coverage   61.65%   61.73%   +0.07%     
==========================================
  Files         354      355       +1     
  Lines       24646    24713      +67     
==========================================
+ Hits        15195    15256      +61     
- Misses       8576     8578       +2     
- Partials      875      879       +4     
Files Coverage Δ
evmrpc/simulate.go 70.83% <100.00%> (+0.74%) ⬆️
app/app.go 65.60% <0.00%> (-0.17%) ⬇️

... and 6 files with indirect coverage changes

evmrpc/simulate.go Fixed Show resolved Hide resolved
@stevenlanders stevenlanders merged commit 3e4db93 into seiv2 Mar 27, 2024
38 checks passed
@stevenlanders stevenlanders deleted the fix-timestamp-in-calls branch March 27, 2024 23:21
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* fix timestamp for specific block queries

* add hardhat test

* fix consistency of trace calls with timestamps

* fix dereference possibility

* move comment so i don't go nuts
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* fix timestamp for specific block queries

* add hardhat test

* fix consistency of trace calls with timestamps

* fix dereference possibility

* move comment so i don't go nuts
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* fix timestamp for specific block queries

* add hardhat test

* fix consistency of trace calls with timestamps

* fix dereference possibility

* move comment so i don't go nuts
udpatil pushed a commit that referenced this pull request Apr 18, 2024
* fix timestamp for specific block queries

* add hardhat test

* fix consistency of trace calls with timestamps

* fix dereference possibility

* move comment so i don't go nuts
udpatil pushed a commit that referenced this pull request Apr 19, 2024
* fix timestamp for specific block queries

* add hardhat test

* fix consistency of trace calls with timestamps

* fix dereference possibility

* move comment so i don't go nuts
udpatil pushed a commit that referenced this pull request Apr 19, 2024
* fix timestamp for specific block queries

* add hardhat test

* fix consistency of trace calls with timestamps

* fix dereference possibility

* move comment so i don't go nuts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants