-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ct EVM transactions decryption #2046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with 2 small nits!
if err != nil { | ||
return nil, err | ||
} | ||
func GetAuditorFromCtAuditor(address string, ctAuditor cttypes.CtAuditor) (*cttypes.Auditor, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Might add a comment here documenting the difference between an Auditor and a CtAuditor
if err != nil { | ||
return nil, err | ||
} | ||
argsBz := dyanmicFeeTx.Data[4:] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could add some comment here explaining what you're getting from Data[4:]
Describe your changes and provide context
Updating
ct tx
command to support EVM transactions decryptionTesting performed to validate your change