Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ct EVM transactions decryption #2046

Merged
merged 8 commits into from
Jan 27, 2025
Merged

Conversation

dssei
Copy link
Contributor

@dssei dssei commented Jan 17, 2025

Describe your changes and provide context

Updating ct tx command to support EVM transactions decryption

Testing performed to validate your change

  • local testing
  • unit tests for existing refactored code

@dssei dssei self-assigned this Jan 17, 2025
Copy link
Contributor

@mj850 mj850 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 2 small nits!

if err != nil {
return nil, err
}
func GetAuditorFromCtAuditor(address string, ctAuditor cttypes.CtAuditor) (*cttypes.Auditor, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Might add a comment here documenting the difference between an Auditor and a CtAuditor

if err != nil {
return nil, err
}
argsBz := dyanmicFeeTx.Data[4:]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could add some comment here explaining what you're getting from Data[4:]

@dssei dssei merged commit b1b9047 into feature/ct_module Jan 27, 2025
28 checks passed
@dssei dssei deleted the ct_evm_transaction_decryption branch January 27, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants