Avoid panic tx error message in debug trace #2057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Previously when we used a dynamic gas precompile with an insufficient gas provided the transaction trace would look like this:
This is because the precompile's gas meter panics. This PR catches that panic so that trace can look something like this. Notably, it fails with the canonical "execution reverted" instead of "panic occurred":
Testing performed to validate your change
added integration tests