Refactor reentrant flag to be set during channel creation. #1738
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnelImpl` to remove ambiguity between public and private calls.
… of when starting capture as it is determined by the PF_RING_REENTRANT flag. - Added ability to choose if `openSingleChannelImpl` will open w/reenterant flag.
Dimi1010
commented
Mar 23, 2025
| int res = openSingleRxChannel(ringName.c_str(), &m_PfRingDescriptors[i]); | ||
| // todo: Shouldn't we use the reentrant mode here? We are opening multiple channels? | ||
| // todo: Potentially only open in reenterant mode if creating N > 1 channels? | ||
| int res = openSingleRxChannelImpl(ringName.c_str(), &m_PfRingDescriptors[i]); |
There was a problem hiding this comment.
@seladb Can you please check this code?
Why is the implementation opening multiple Rx channels in non-reentrant mode here, when the other multiple channel function opens them in reentrant mode?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1738 +/- ##
==========================================
- Coverage 83.21% 83.20% -0.01%
==========================================
Files 282 282
Lines 48732 48732
Branches 10354 10552 +198
==========================================
- Hits 40550 40548 -2
- Misses 7052 7056 +4
+ Partials 1130 1128 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split of #1668
This PR aims to standardize
m_ReentrantModeto be set during the channel opening phase instead of the capture initialization phase as it is determined by the opening flags. The currently used implementation essentially assumes the what the reentrant mode is based on the function being called to start the capture, instead of recording the correct value.