Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added commands and variables to run something when client connect/disconnect #169

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

skipperro
Copy link

  • Added support for SELKIES_START_AFTER_CONNECT and SELKIES_START_AFTER_DISCONNECT variables
  • Added support for --start-after-connect and --start-after-disconnect start arguments
  • Removed duplicated base64 import in signalling_web.py

Additional context

  • I confirm that this pull request is relevant to the scope of this project. If you know that upstream projects are the cause of this problem, please file the pull request there.
  • I confirm that this pull request has been tested thoroughly and to the best of my knowledge that additional unintended problems do not arise.
  • I confirm that the style of the changed code conforms to the overall style of the project.
  • I confirm that I have read other open and closed pull requests and that duplicates do not exist.
  • I confirm that I have justified the need for this pull request and that the changes reflect the fix for the specified problem.
  • I confirm that no portion of this pull request contains credentials or other private information, and it is my own responsibility to protect my privacy.
  • I confirm that the authors of this pull request does not willfully breach or infringe legal regulations, in any and all global law, regarding trademarks, trade names, logos, patents, or any and all other forms of external intellectual property, as well as adhering to software license terms of open-source and proprietary software projects.

- Added support for SELKIES_START_AFTER_CONNECT and SELKIES_START_AFTER_CONNECT variables
- Added support for --start-after-connect and --start-after-disconnect start arguments
- Removed duplicated base64 import in signalling_web.py
@ehfd
Copy link
Member

ehfd commented Dec 22, 2024

I will review this but will take weeks before I gain enough dedicated time. Thank you!

Copy link
Member

@ehfd ehfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall code style by Dan Isla prefers using a Python-native variable over os.environ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants