-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Polynomials Rule #25
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
04bb0ee
added rules for patterns w/o constraints
aliang8 f37f48c
added rules test, some errors
aliang8 5745443
rm file
aliang8 b462d8a
rm file
aliang8 3ca4c7f
format
aliang8 adcbc10
fixed tabing, remove comments, added rules, need to check variables
aliang8 3cb89d4
added extra test cases, not done
aliang8 75ab164
not sure what's up with these tests
aliang8 3beef3e
finished adding cases, still some errors
aliang8 c35f087
fixed merge errors
aliang8 20bc705
one last test
aliang8 336c5c3
fixed tests and yarn
aliang8 3dbb8cd
done
aliang8 2335275
removed lint, added TODO
aliang8 d91eb26
merging
aliang8 7fdbd7e
rebasing
aliang8 e8e86a1
merge
aliang8 7a3e271
merged
aliang8 fbd4938
merge
aliang8 3ea7468
merge
aliang8 96d2bb9
merged
aliang8 caa0ae0
addingPolynomials
aliang8 14a091f
fixed comments
aliang8 aa21a98
added more tests, one of them fails
aliang8 08b3ca1
remove . file
aliang8 03ffdf1
merge
aliang8 648f0f7
remove alphabetize
aliang8 632b525
fixed comments
aliang8 7403644
removed comment
aliang8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we run
COLLECT_LIKE_TERMS
first then we shouldn't have to do any grouping.