Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated error to rightly signify what happened and work around #185

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: updated error to rightly signify what happened and work around #185

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0e5968
fix: updated error to rightly signify what happened and work around
theoomoregbee Jan 29, 2018
93eac4a
Merge branch 'master' into patch-1
theoomoregbee Mar 14, 2018
aac0490
fix: possible cause of error, and no need for npm token create
theoomoregbee Mar 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/lib/npm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ async function getNpmToken({npm, options}) {

const uri = url.resolve(npm.registry, '-/user/org.couchdb.user:' + encodeURIComponent(npm.username));

const {err, token} = await new Promise(resolve => {
const {err, token, possibleCause=''} = await new Promise(resolve => {
client.request(uri, {method: 'PUT', body}, async (err, parsed, raw, response) => {

if (err && err.code === 'E401' && response.headers['www-authenticate'] === 'OTP') {
await askForOTP(uri, body, npm);
resolve({token: npm.token});
Expand All @@ -38,17 +39,17 @@ async function getNpmToken({npm, options}) {
body,
})
.then(res => resolve(res))
.catch(err => resolve({err}));
.catch(err => resolve({err, possibleCause: err.message}));
} else if (err) {
resolve({err});
resolve({err, possibleCause:'Bad username or password'});
} else {
resolve(response.body);
resolve(parsed);// at this point a token was created, so no need for future `npm token create`
}
});
});

if (err) log.verbose(`Error: ${err}`);
if (!token) throw new Error(`Could not login to npm.`);
if (!token) throw new Error(`Could not login to npm. ${possibleCause}`);

if (options.keychain) {
passwordStorage.set(npm.username, npm.password);
Expand Down