fix(pipeline): Add name parameter to avoid 400 error #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This plugin doesn' work anymore without the "name" for all newer version of Gitlab. |
merlosy
reviewed
Mar 31, 2022
| @@ -88,6 +88,7 @@ module.exports = async (pluginConfig, context) => { | |||
| const json = { | |||
| /* eslint-disable camelcase */ | |||
| tag_name: gitTag, | |||
| name: `Bump tag: ${gitTag}`, | |||
There was a problem hiding this comment.
The name could optionally be resolved by the plugin config so that:
- if it is defined, the given value is set
- if it is not defined, this value is assigned by default
like:
name: pluginConfig.name || `Bump tag: ${gitTag}`,
merlosy
suggested changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related with this issue.
#192
The Gitlab api is returning error when make a request. The status code is 400 and the error is:
{"error":"name is missing"}