Add Home link placement in the header for better accessibility

[Chirag-S-Kotian]

Description

This PR updates the Home link functionality and layout as per the review feedback. The goal is to ensure the Home link is easily accessible and seamlessly integrated into the header, improving the overall user experience.

Updates:

• Improved Home link placement in the header for better accessibility and consistency.
• Adjusted spacing and layout to align with UI best practices.
• Ensured that the Home link redirects to the root page ("/") without any issues.

Feedback Incorporated:

• Refined the link placement to make it more prominent and user-friendly.
• Enhanced visual hierarchy in the header to maintain clarity and ease of use.

Screenshots

Checklist:

• Verified the Home link navigation works as expected.
• Ensured no visual or functional issues with the layout changes.
• Incorporated feedback from previous PR review.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
semaphore-boilerplate	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 23, 2024 1:03pm

[Chirag-S-Kotian]

review please author

[vplasencia]

Hey @Chirag-S-Kotian thank you very much!

[Chirag-S-Kotian]

IF YOU NEED ANY OTHER HELP PLEASE LET ME KNOW.

[vplasencia]

Hey @Chirag-S-Kotian I left a comment to improve UX. Feel free to push the new commit here without closing the Pull Request.

[Chirag-S-Kotian]

i fixed the link problem.

[vplasencia]

Could you run yarn prettier and push the changes?

[vplasencia]

Hey! I see that yarn prettier:write worked well. Could you remove the package-lock.json and yarn.lock files. Any package version should be updated here.

[vplasencia]

There is no need to update these versions.

[Chirag-S-Kotian]

Could you please tell me how to remove package.json and yarn.lock , should I delete from my repo?

[vplasencia]

Hey!

You can delete the package-lock.json file from your repo.

Regarding the yarn.lock file, if you keep the current versions of all the packages, everything should be fine and you won't need to remove this file. To keep the current versions of all the packages you need to have this: "@semaphore-protocol/data": "4.3.1" instead of this: "@semaphore-protocol/data": "^4.4.1" and "next": "14.1.0" instead of "next": "^14.2.15" in the package.json file.

Please let me know if you have any other questions.

[Chirag-S-Kotian]

okay i removed both and updated package.json file

[vplasencia]

Hey! Great! Thank you! Please, could you create an empty yarn.lock file in the root of the project and run the command yarn and push the changes? The yarn.lock file should still be in the repo but this PR shouldn't modify it.

After that, I think the PR is ready.

[Chirag-S-Kotian]

i did it anyway and pushed same yarn.lock which is present in boilerplate repo

[vplasencia]

Hey! The new yarn.lock file is almost correct. If you run yarn, it will be updated and you can push the change. The change will be just adding a line at the end of the file.

The yarn.lock file should not be part of these files after you push the change: https://github.com/semaphore-protocol/boilerplate/pull/76/files

Right now it's there: https://github.com/semaphore-protocol/boilerplate/pull/76/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de

[Chirag-S-Kotian]

okay changes are complete.

[vplasencia]

Hey! Thank you @Chirag-S-Kotian!

I added two suggestions. Please push the changes when you update those versions and run yarn.

[vplasencia]

Hey @Chirag-S-Kotian thank you very much!

[gitpoap-bot]

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Semaphore Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

[Chirag-S-Kotian]

thank you for your time, if you have anything other issue please let me know.