Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support links in sidebar #184

Merged
merged 6 commits into from
Nov 20, 2024
Merged

feat: support links in sidebar #184

merged 6 commits into from
Nov 20, 2024

Conversation

kopecs
Copy link
Contributor

@kopecs kopecs commented Nov 20, 2024

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests included or PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was for any user-facing change
  • Change has no security implications (otherwise, ping security team)

If you're unsure about any of this, please see:

Adds a new section in the sidebar with links to join slack, view documentation, or email support:
image

@kopecs kopecs requested a review from ajbt200128 November 20, 2024 19:17
@kopecs kopecs marked this pull request as ready for review November 20, 2024 19:18
@kopecs
Copy link
Contributor Author

kopecs commented Nov 20, 2024

Rebasing to get updated test list

Copy link
Contributor

@ajbt200128 ajbt200128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we probably want to rename the sidebar to just Semgrep:

"title": "Semgrep Search",

@kopecs
Copy link
Contributor Author

kopecs commented Nov 20, 2024

Ah true.

@kopecs kopecs merged commit da5e3dd into master Nov 20, 2024
9 checks passed
@kopecs kopecs deleted the cooper/code-7797 branch November 20, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants