Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only show sign in/out as relevant #187

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

kopecs
Copy link
Contributor

@kopecs kopecs commented Nov 22, 2024

This uses the new context key for login status. However, since that context key is still frequently stale due how the current login flow works with our LSP extensions, we should hold off on merging this one until I clean that up too.

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests included or PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was for any user-facing change
  • Change has no security implications (otherwise, ping security team)

If you're unsure about any of this, please see:

This uses the new context key for login status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant