Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate for 5.3.7 #1006

Merged
3 commits merged into from
Mar 11, 2024
Merged

Release candidate for 5.3.7 #1006

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc6462b
Use MarkAllButFirstSubBags for T_BIPART
fingolfin Mar 6, 2024
7c7bfe2
Fix mailmap
james-d-mitchell Mar 11, 2024
3cb60b5
Update version numbers etc for v5.3.7
james-d-mitchell Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use MarkAllButFirstSubBags for T_BIPART 
T_BIPART consists of a general pointer not managed by GAP's GC,
plus two bag references (which may be NULL). Hence we can use
MarkAllButFirstSubBags instead of a custom marking function.
  • Loading branch information
@fingolfin @james-d-mitchell
fingolfin authored and james-d-mitchell committed Mar 9, 2024
commit dc6462b5797a90b70ba7b77e5d179369fdc84c61
11 changes: 1 addition & 10 deletions src/pkg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,15 +332,6 @@ void TBlocksObjLoadFunc(Obj o) {
ADDR_OBJ(o)[0] = reinterpret_cast<Obj>(blocks);
}

void TBipartObjMarkSubBags(Obj o) {
if (ADDR_OBJ(o)[1] != NULL) {
MarkBag(ADDR_OBJ(o)[1]);
}
if (ADDR_OBJ(o)[2] != NULL) {
MarkBag(ADDR_OBJ(o)[2]);
}
}

// Filters for IS_BIPART, IS_BLOCKS

Obj IsBipartFilt;
Expand Down Expand Up @@ -512,7 +503,7 @@ static Int InitKernel(StructInitInfo* module) {
SaveObjFuncs[T_BIPART] = TBipartObjSaveFunc;
LoadObjFuncs[T_BIPART] = TBipartObjLoadFunc;

InitMarkFuncBags(T_BIPART, &TBipartObjMarkSubBags);
InitMarkFuncBags(T_BIPART, &MarkAllButFirstSubBags);
InitFreeFuncBag(T_BIPART, &TBipartObjFreeFunc);

ProdFuncs[T_BIPART][T_BIPART] = BIPART_PROD;
Expand Down
Loading