Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeSemilattice constructor #995

Merged
merged 16 commits into from
Mar 15, 2024
Merged

Add FreeSemilattice constructor #995

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
335f388
Adding Free Semilattice constructor
Jun2M Feb 7, 2024
5fb0319
For Transformation and PartialPerm Semigroups
Jun2M Feb 7, 2024
4685a06
Lint
Jun2M Feb 8, 2024
721a464
Update semicons.gd
Jun2M Feb 10, 2024
c4f56d9
Merge branch 'main' into main
Jun2M Feb 10, 2024
1ec0a1a
Add docs and a whole lot of tests
Jun2M Feb 10, 2024
f35961a
Minor test fix
Jun2M Feb 11, 2024
9ae4fd9
Merge branch 'main' into main
Jun2M Feb 14, 2024
432322b
Dial back on the number of tests
Jun2M Feb 14, 2024
708e4c1
Merge branch 'main' into main
james-d-mitchell Mar 11, 2024
917be05
Apply suggestions from code review
james-d-mitchell Mar 11, 2024
7977c3b
Change tst to reflect the new error msg
Jun2M Mar 12, 2024
f7338a2
Merge branch 'main' into main
Jun2M Mar 12, 2024
b2463bb
Add Monoid constructors to FreeSemilatticeCons
Jun2M Mar 13, 2024
19266ad
Unbind _IsXMonoid in semicons.gi
Jun2M Mar 13, 2024
58013b4
Update semicons.xml and semicons.gi files
Jun2M Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change tst to reflect the new error msg
  • Loading branch information
@Jun2M
Jun2M committed Mar 12, 2024
commit 7977c3b3a31b9cc292f43287f7461a402114dd35
1 change: 1 addition & 0 deletions gap/semigroups/semicons.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,7 @@ function(arg...)
S := FreeSemilatticeCons(filter, n);

SetSize(S, 2 ^ n - 1);
SetIsSemilattice(S, true);

return S;
end);
Expand Down
3 changes: 1 addition & 2 deletions tst/standard/semigroups/semicons.tst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,8 +505,7 @@ gap> S := FreeSemilattice(IsPartialPermSemigroup, 0);
Error, the arguments must be a positive integer or a filter and a positive int\
eger
gap> S := FreeSemilattice(IsPermGroup, 1, 1);
Error, the arguments must be a positive integer or a filter and a positive int\
eger
Error, expected 2 arguments found 3
gap> S := FreeSemilattice(IsPartialPermSemigroup, true);
Error, the arguments must be a positive integer or a filter and a positive int\
eger
Expand Down