Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed failed test cases due to go upgrade #477

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Aug 6, 2024

Fixes

  1. As of Go 1.22, “go get is no longer supported outside of a module”, Thus it was failing go get command.
    Failure:
0.256 go get -t -v ./...
0.258 go: modules disabled by GO111MODULE=off; see 'go help modules'

Link: https://github.com/sendgrid/sendgrid-go/actions/runs/9859530453/job/27223508248#step:6:231

Issue: golang/go#66080

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@sbansla sbansla marked this pull request as draft August 6, 2024 09:45
@sbansla sbansla marked this pull request as ready for review August 6, 2024 10:08
@lopezator
Copy link
Contributor

lopezator commented Aug 6, 2024

Sorry, I didn't see this before raising:

#478

Just a comment. It docker compose (v2) can be used safely, maybe it's a better solution rather than installing docker-compose (v1).

@sbansla
Copy link
Contributor Author

sbansla commented Aug 6, 2024

Sorry, I didn't see this before raising:

#478

Just a comment. It docker compose (v2) can be used safely, maybe it's a better solution rather than installing docker-compose (v1).

Yes you are correct, But prism.sh file is in sendgrid/sendgrid-oai and it has been archived and it has docker-compose.yml file.

Note:
We are in the process of evolving sendgrid-go similar to the approach of twilio-go, where all code will be auto-generated based on the OpenAPI specification.

@lopezator
Copy link
Contributor

Understood. If I can help I am open to. If not, feel free to close the other PR and ignore my message. Thank you for your response :)

@sbansla sbansla merged commit c7b120f into main Aug 8, 2024
19 checks passed
@sbansla sbansla deleted the fix-test-cases branch August 8, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants