v0.9.0

senecajs · Nov 26, 2023 · 6b0d55d · 6b0d55d
1 parent 0f705bf
commit 6b0d55d
Show file tree

Hide file tree

Showing 7 changed files with 28 additions and 52 deletions.
diff --git a/dist/gateway-express.d.ts b/dist/gateway-express.d.ts
@@ -1,4 +1,4 @@
-declare type GatewayExpressOptions = {
+type GatewayExpressOptions = {
     auth?: {
         token: {
             name: string;
@@ -22,9 +22,11 @@ declare namespace gateway_express {
             token: {
                 name: string;
             };
-            cookie: import("gubu").Node & {
-                [name: string]: any;
-            };
+            cookie: import("gubu").Node<{
+                maxAge: number;
+                httpOnly: boolean;
+                sameSite: boolean;
+            }>;
         };
         error: {
             next: boolean;

diff --git a/dist/gateway-express.js b/dist/gateway-express.js
diff --git a/dist/gateway-express.js.map b/dist/gateway-express.js.map
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@seneca/gateway-express",
-  "version": "0.8.2",
+  "version": "0.9.0",
   "main": "dist/gateway-express.js",
   "type": "commonjs",
   "types": "dist/gateway-express.d.ts",
@@ -38,17 +38,17 @@
     "node": ">=12"
   },
   "devDependencies": {
-    "@seneca/maintain": "^0.0.22",
-    "@types/jest": "^28.1.6",
-    "esbuild": "^0.15.1",
+    "@seneca/maintain": "^0.1.0",
+    "@types/jest": "^29.5.10",
+    "esbuild": "^0.19.7",
     "esbuild-jest": "^0.5.0",
     "express": "^4.17.1",
-    "jest": "^28.1.3",
+    "jest": "^29.7.0",
     "seneca-msg-test": "^3.4.0",
-    "typescript": "^4.7.4"
+    "typescript": "^5.3.2"
   },
   "peerDependencies": {
-    "@seneca/gateway": ">=0.5.1",
+    "@seneca/gateway": ">=0.8.0",
     "express": ">=4",
     "seneca": ">=3",
     "seneca-promisify": ">=3"

diff --git a/src/gateway-express.ts b/src/gateway-express.ts
@@ -80,6 +80,7 @@ function gateway_express(this: any, options: GatewayExpressOptions) {
 
     // TODO: doc as a standard feature
     // TODO: implement in other gateways
+    // TODO: headers & body as per gateway-lambda
     json.gateway = {
       params: req.params,
       query: req.query,
@@ -110,6 +111,7 @@ function gateway_express(this: any, options: GatewayExpressOptions) {
         }
       }
 
+      // TODO: should also match `headers`
       if (gateway$.header) {
         res.set(gateway$.header)
       }
@@ -190,7 +192,7 @@ gateway_express.defaults = {
     })
   },
   error: {
-    next: true
+    next: false
   }
 }
 

diff --git a/test/foo.js b/test/foo.js
diff --git a/test/gateway-express.test.ts b/test/gateway-express.test.ts
@@ -61,15 +61,19 @@ describe('gateway-express', () => {
 
 
 
-  test('express-error-basic', done => {
+  test('express-error-next', done => {
     Seneca({
       legacy: false
     })
       .test()
       .quiet()
       .use('promisify')
       .use('gateway')
-      .use(GatewayExpress)
+      .use(GatewayExpress, {
+        error: {
+          next: true
+        }
+      })
 
       .message('foo:1', async function(msg: any) {
         return msg
@@ -93,7 +97,7 @@ describe('gateway-express', () => {
           }
 
           await handler(req, res, (err: any, _req: any, _res: any, _next: any) => {
-            console.log(err)
+            // console.log(err)
 
             expect(err).toMatchObject({
               name: 'Error',
@@ -120,11 +124,7 @@ describe('gateway-express', () => {
       .use('promisify')
       .use('gateway')
 
-      .use(GatewayExpress, {
-        error: {
-          next: false
-        }
-      })
+      .use(GatewayExpress)
 
       .message('foo:1', async function(msg: any) {
         return msg