rinari repository not up to date with rails #198
Conversation
|
We should either drop it, or update it. However there is an important caveat: Rinari bundles some tools used in the ruby-bundle. I'm not sure what the current situation is and if we are overwriting these libraries or are actually using them.
|
|
@senny Rinari doesn't bundle |
|
oh, that is great news! I've given up on Rinari some time ago but I think it's a good time to revisit this decision. @tonini are you interested in working on a PR with an updated version of Rinari? I'm willing to work with it for some time to see how it fits into cabbage. @purcell do you happen to know if Rinari works with Enhanced-Ruby-Mode? |
|
@senny Great! sure I will make a PR with the updated version. |
|
@senny Yes, I think so. We have at least one chunk of code (syntax-highlighting of Rails keywords) which explicitly supports both ruby-mode and enhanced-ruby-mode. |
|
@purcell great. I'm gonna try those in combination. Thank you for jumping in and sharing your insight 💛 . |
the rinari package created by @technomancy isn't maintained anymore and behind rails version 3/4. The rinari fork under github.com/eschulte/rinari is up to date with the current state of rails. * https://github.com/eschulte/rinari.git is the new source of the rinari version which cabbage use. * cabbage need to provide the `findr` package because it isn't included in the `jump` package repository anymore.
|
@senny the branch is ready for testing. You have to |
Hi,
rinariisn't actually working well withrails 3/4and one of the reasons might be that there're no updates for the last 5 years.the
rinarifork https://github.com/eschulte/rinari is well maintained by @purcell, maybe we consider to use that source instead?@senny whats your opinion on that?