Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added board information to doc links #432

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Thiemann96
Copy link
Contributor

@Thiemann96 Thiemann96 commented Mar 14, 2025

closes #420

Copy link

Tests

Test Name Status Flaky Duration
Blockly Editor Page Tests [Blockly] visits the editor page 912ms
Blockly Editor Page Tests [Blockly] selects senseBox ESP 1.1s
Blockly Editor Page Tests [Blockly] compiles code 11.2s
Code Editor Page Tests [CodeEditor] visits the code editor page 1.3s
Code Editor Page Tests [CodeEditor] selects senseBox ESP 465ms
Code Editor Page Tests [CodeEditor] compiles code 601ms
Code Editor Page Tests [CodeEditor] opens reset dialog 610ms
Code Editor Page Tests [CodeEditor] fetches libraries 1.2s

Github Test Reporter by CTRF 💚

@mariopesch
Copy link
Member

@Thiemann96 i think we should add the board identifier not in the block definition but in the action which already extracts the information from the block: https://github.com/sensebox/React-Ardublockly/blob/main/src/actions/workspaceActions.js#L32

@Thiemann96
Copy link
Contributor Author

why though?

applying this to all blocks would imply all blocks documentation lead to docs.sensebox.de (for example documentation for 'function' blocks) and moreover there is a documentation for every sensor with the respective board (which there is not (yet))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants