roboeyes (not animated) #443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes for old connect app
update function name of isVisible
|
I am open to suggestions about how the positions should be named in the UI. They are currently in english. I feel like translating all of those would be a drag tho... |
Tests
Github Test Reporter by CTRF 💚 |
Tests
Github Test Reporter by CTRF 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#394
The block doesnt need to be in a "print on display" block, because the
showEyes()function of the library already displays on the display. I had to callshowEyes()four times, for the animation to finish. I didnt include blinking, because then we would have to regularly call thedrawEyes()/update()function (e.g. in a parallel process). The code for the parallel process gets too complicated imo. Because for example we would also have to stop the process if sth else is displayed. Its possible but the arduino code would become somewhat advanced.Also the roboeyes library has to be included after the display is declared. Thats why the include is part of the definition and not the library code.