Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CHAT file reader #174

Merged
merged 9 commits into from
Nov 14, 2024
Merged

Added CHAT file reader #174

merged 9 commits into from
Nov 14, 2024

Conversation

wilke0818
Copy link
Collaborator

  • Reads and converts .cha files to lists of script lines for use in SenseLab

@wilke0818 wilke0818 requested a review from fabiocat93 October 18, 2024 14:57
Copy link
Collaborator

@fabiocat93 fabiocat93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to add unit tests as needed

@wilke0818
Copy link
Collaborator Author

we'd need a .cha file for that. not sure what a minimal file might look like. also this currently won't work as I didn't add pylangacq to the requirements because as discussed offline, my poetry is currently broken.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.58%. Comparing base (113721a) to head (9a6a7f2).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...enselab/utils/data_structures/talk_bank_helpers.py 89.28% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   60.24%   60.58%   +0.33%     
==========================================
  Files         113      116       +3     
  Lines        4017     4059      +42     
==========================================
+ Hits         2420     2459      +39     
- Misses       1597     1600       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiocat93
Copy link
Collaborator

we'd need a .cha file for that. not sure what a minimal file might look like. also this currently won't work as I didn't add pylangacq to the requirements because as discussed offline, my poetry is currently broken.

  • feel free to create a basic .cha file starting from some you find on CHILDES
  • I would recommend cloning the repo from scratch. I have tested the installation today and it works for me

@fabiocat93
Copy link
Collaborator

@wilke0818 have you ever found what was the source of the problem? (and maybe a solution to it)

@wilke0818
Copy link
Collaborator Author

I thought you found that the solution was to not use relative paths?

@fabiocat93
Copy link
Collaborator

I thought you found that the solution was not to use relative paths?

If this is completed, I will merge it then!

@fabiocat93 fabiocat93 merged commit 237ce92 into main Nov 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants