Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancing speech enhancement #244

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

fabiocat93
Copy link
Collaborator

Description

  • added support to speechbrain's SpectralMaskEnhancement
  • worked around speechbrain's issues with enhancing long audio clips (see Bug: Speech enhancement on long audio clips #243) by splitting them in shorter clips and concatenating their enhanced versions

Related Issue(s)

-#243

Motivation and Context

  • to have a wider choice of speech enhancement solutions
  • to enable speech enhancement on longer audio clips

How Has This Been Tested

  • CPU and GPU unit tests
  • Tutorial

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@fabiocat93 fabiocat93 added bug Something isn't working enhancement New feature or request release minor Minor release to-test to-test-gpu labels Jan 31, 2025
@fabiocat93 fabiocat93 self-assigned this Jan 31, 2025
@fabiocat93 fabiocat93 linked an issue Jan 31, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.53%. Comparing base (113721a) to head (76d733e).
Report is 122 commits behind head on main.

Files with missing lines Patch % Lines
src/tests/audio/tasks/speech_enhancement_test.py 78.57% 3 Missing ⚠️
...elab/audio/tasks/speech_enhancement/speechbrain.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   60.24%   65.53%   +5.29%     
==========================================
  Files         113      128      +15     
  Lines        4017     4599     +582     
==========================================
+ Hits         2420     3014     +594     
+ Misses       1597     1585      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiocat93 fabiocat93 merged commit d106073 into main Jan 31, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request minor Minor release release to-test to-test-gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Speech enhancement on long audio clips
2 participants