Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing timestamped-ASR with long audio recordings #246

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

fabiocat93
Copy link
Collaborator

Description

Patch for fixing issues with timestamped-ASR with long audio recordings (same as here: huggingface/transformers#21262). In a related issue (huggingface/transformers#2615 (comment)), they recommended reducing the batch size and it seems to work from my tests.

How Has This Been Tested?

unit tests (locally and on github)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.53%. Comparing base (113721a) to head (dc9b9ae).
Report is 130 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   60.24%   65.53%   +5.29%     
==========================================
  Files         113      128      +15     
  Lines        4017     4599     +582     
==========================================
+ Hits         2420     3014     +594     
+ Misses       1597     1585      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiocat93 fabiocat93 changed the title Update huggingface.py Fixing timestamped-ASR with long audio recordings Feb 1, 2025
@fabiocat93 fabiocat93 merged commit 8523264 into main Feb 1, 2025
59 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants