Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix should_content not correctly matching pdnsutil output #171

Closed
wants to merge 1 commit into from
Closed

Fix should_content not correctly matching pdnsutil output #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/puppet/type/powerdns_zone.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,11 @@
if r[:rname] == '.'
content.push([r[:target_zone], r[:rttl], r[:rclass], r[:rtype], r[:rcontent]].join("\t"))
else
content.push([r[:rname] + '.' + r[:target_zone], r[:rttl], r[:rclass], r[:rtype], r[:rcontent]].join("\t"))
content.push([(r[:rname] + '.' + r[:target_zone]).downcase, r[:rttl], r[:rclass], r[:rtype], r[:rcontent]].join("\t"))
end
# rubocop:enable Style/StringConcatenation
end
content.push("$ORIGIN .\n") # add this, since it's always in the output..
content.push("$ORIGIN .") # add this, since it's always in the output..

Check failure on line 143 in lib/puppet/type/powerdns_zone.rb

View workflow job for this annotation

GitHub Actions / Static & Spec Tests (Ruby 3.1, Puppet 7.0) 

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)

Check failure on line 143 in lib/puppet/type/powerdns_zone.rb

View workflow job for this annotation

GitHub Actions / Static & Spec Tests (Ruby 3.2, Puppet 7.0) 

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)

Check failure on line 143 in lib/puppet/type/powerdns_zone.rb

View workflow job for this annotation

GitHub Actions / Static & Spec Tests (Ruby 3.1, Puppet 8.0) 

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)

Check failure on line 143 in lib/puppet/type/powerdns_zone.rb

View workflow job for this annotation

GitHub Actions / Static & Spec Tests (Ruby 3.2, Puppet 8.0) 

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)
content.sort.join("\n")
end
# rubocop:enable Metrics/AbcSize
Expand Down
Loading