Fix node version issue causing node-gyp rebuild error #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I've tested locally, now it works at nodejs v20.17 |
sentialx
reviewed
Nov 14, 2024
example.js
Outdated
| const requiredNodeVersion = '13.11.0'; | ||
| const currentNodeVersion = process.versions.node; | ||
|
|
||
| if (currentNodeVersion < requiredNodeVersion) { |
There was a problem hiding this comment.
I think this should be enforced at the package.json level, not at the API usage
There was a problem hiding this comment.
Fixed, I've removed it from example, but changed line endings from CRLF to LF, without actual changes. Squashed to single commit.
popstas
force-pushed
the
fix-node-version
branch
from
8ba54e2 to
100444a
Compare
Related to sentialx#68 --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/sentialx/node-window-manager/issues/68?shareId=XXXX-XXXX-XXXX-XXXX).
popstas
force-pushed
the
fix-node-version
branch
from
100444a to
bf4a359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #68
For more details, open the Copilot Workspace session.