Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

dds_glossary/database.py: improve init_engine #72

Closed
wants to merge 3 commits into from
Closed

dds_glossary/database.py: improve init_engine #72

wants to merge 3 commits into from

Conversation

sami-m-g
Copy link
Contributor

Description

Removed calling Base.metadata.create_all when database already exists
Disposed engine on dropping the database
Added pool_recycle, pool_size and max_overflow

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

  • I'm aware of the code of conduct.
  • I'm aware of the contributing guidelines.
  • I've created logical separate commits and followed the commit message format.
  • If this PR resolves or addresses an issue, I've linked it in the commit message.
  • I've added relevant test cases.
  • I've added relevant documentation.
  • I've NOT included third-party code (copy/pasted source code or new dependencies).
    • If you have added third-party code (copy/pasted or new dependencies), please make sure this has been discussed in a github issue..

@sami-m-g sami-m-g added the enhancement New feature or request label Jun 26, 2024
@sami-m-g sami-m-g requested a review from jsvgoncalves June 26, 2024 09:15
@sami-m-g sami-m-g self-assigned this Jun 26, 2024
@sami-m-g sami-m-g closed this Jun 26, 2024
@jsvgoncalves jsvgoncalves removed their request for review September 5, 2024 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant